On Mon, 7 Mar 2011 22:30:28 +0100, Lukas Kahwe Smith <[email protected]> wrote: > On 07.03.2011, at 22:05, Lukas Kahwe Smith wrote: > >> >> On 21.02.2011, at 18:36, Lukas Kahwe Smith wrote: >> >>> >>> On 21.02.2011, at 08:22, Lukas Kahwe Smith wrote: >>> >>>> >>>>>> I was also suggesting to remove support for returning anything but a >>>>>> Response, but i guess keystoke haters wouldnt like that :) >>>>> >>>>> This has nothing to do with keystrokes. >>>> >>>> if its not about keystrokes why are we using event for this? why not >>>> use a custom Response class that receives the parameter array and reads >>>> out the annotations? an event really only makes sense if you expect >>>> zero to multiple subscribers. but the franeworkextra using controllers >>>> really expect exactly one subscriber. >>> >>> >>> saw you switched to notifyUntil(): >>> https://github.com/symfony/symfony/commit/fc372bc217385dc5130989150e979537140771a3 >>> >>> think this is better than before, but I still disagree with this entire >>> concept. the same functionality of frameworkextrabundle could be >>> achieved with a Response subclass and it would be a much cleaner design. >> >> >> ok noticing that i still have trouble accepting core.view. so sure, some >> people like magic which lets them type less. so if its too much trouble >> to type a use statement and a return statement in each action, can we at >> least require these people to extend from base class that adds a few >> helpers so that they can then simply do: >> >> return $this->doMagic(array('name' => $name)); >> >> instead of >> >> return array('name' => $name); >> >> of they really hate typing that much, they can also just do: >> >> return $this['m'] = array('name' => $name); >> >> i just don't get why we would accept mixed return values from Controller >> actions. its just insanely ugly and inconsistent right at the very core >> of Symfony2. > > > on IRC Benjamin explained that the magic in FrameworkExtraBundle needs to > know which action is being called in order to work. this to me just means > that instead of registering the magic in core.view it should be registered > in core.request. this way whatever data the FrameworkExtraBundle needs > would be configured before the controller is called, making it again > possible to just use some helper method to apply the annotation magic.
No, i said since controller invocation uses reflection it needs explicit method names, so you cannot hook into the pre and post invocation of a controller there, which is why core.view exists. > > so in other words, how many characters saved typing do we require to add > some magic into the Symfony2 core because nothing in FrameworkExtraBundle > really requires making the contract between kernel and Controller fuzzy by > optionally supporting on Response return values. > > regards, > Lukas Kahwe Smith > [email protected] -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
