I think you shouldn't put too much effort into the builder classes as these will never be "clean" unless we abandon the fluid interface. The builder classes' only responsibility is the construction of actual node objects, and these node objects contain the business logic that is then cleanly separated in several different node classes. You'll not be able to achieve the same clean separation in the builder classes.
Kind regards, Johannes On Sat, Mar 12, 2011 at 4:24 PM, Victor Berchet <[email protected]>wrote: > That's the only solution I found to work around PHP not supporting > multiple inheritance: ArrayNodeDefinition should extend NodeBuilder > but it already extends NodeDefinition... > > On Mar 12, 3:04 pm, Christophe COEVOET <[email protected]> wrote: > > Le 12/03/2011 14:49, Victor Berchet a crit : > > > > > Lukas: > > > > > Thanks for the details. > > > > > All: > > > > > I have just pushed a new commit to my branch: > > >https://github.com/vicb/symfony/tree/cfg_refactor > > > > > That's just a proto for now (the code is dirty), waiting for some > > > feedback. > > > > > This last commit breaks the configuration API, and only the Framework, > > > Twig and Zend Bundles have been updated. > > > > > What about being able to dump the configuration to XML (this would be > > > done in the NodeDefinition classes) and generate docs and XSD files > > > using XSLT ? > > > > > Cheers, > > > Victor > > > > I don't see the reason of adding a ->children() call around the > > children. This extra level of builder seems weird to me. > > It breaks the BC and makes the Configuration class more verbose. What is > > the purpose of this change ? > > > > -- > > Christophe | Stof > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
