On Wednesday, March 30, 2011 5:49:51 PM UTC+2, Kris Wallsmith wrote: > > Here’s some background on my thinking… > > This is a change I’ve been wanting to make ever since Symfony2 was first > released at sflive2010. The inconsistency I saw back then, which we’re all > used to now, is that we needed to include “Bundle” when referencing a > controller (i.e. BlogBundle:Post:show) but not “Controller” or “Action” > (i.e. BlogBundle:PostController:showAction). Dropping these suffixes makes > sense because this is a documented syntax and developers know that these > strings denote bundle, controller and action. > > You're completely right here. I had not realized that this was just removing the last suffix out of the three, and that there were two suffixes already "removed" from the shortcut notation.
Explained like this, the Bundle suffix removal starts to make a bit more sense, at least, to me. That being said, I don’t mind if we revert the change. Let’s just be sure we > considering this issue from the perspective of a new user, not from our > perspective of someone who has been using the framework for a year. > > Thanks! > k > > On Wednesday, March 30, 2011 at 7:29 AM, ryan weaver wrote: > > Some friendly-easy-simple background :) > > The name of a bundle is "created" via a Bundle::getName() method. This has > a default implementation that almost all bundles use without. > > Formerly, the default name was created by grabbing the last part of the > fully-qualified name of the bundle class (Acme\AcmeBlogBundle -> > AcmeBlogBundle). > > The change discussed here was simply *how* that default name is calculated. > The only change was that the word "Bundle" was removed from the end so that > the name of the Acme\AcmeBlogBundle bundle defaults to "AcmeBlog". > > You can see this all here (the change is line 134): > https://github.com/symfony/symfony/pull/401/files#L54L125 > > I'm also +1 for changing it back, after - shamefully - being +1 for making > the change in the first place :/. But let's make sure everyone understands > and comes to some sort of agreement. i'll even update the docs if we change > it back :) > > Thanks! > > Ryan Weaver > US Office Head & Trainer - KnpLabs - Nashville, TN > http://www.knplabs.com <http://www.knplabs.com/en> > http://www.thatsquality.com > Twitter: @weaverryan > > > On Wed, Mar 30, 2011 at 8:54 AM, Henrik Bjornskov <[email protected]>wrote: > > Bundles are essentially a collection of classes or a namespace that only > have a special meaning for Symfony2 projects, i see bundles as Mini > Components. If something isnt big enough for its own dedicated Component it > put it in a bundle, else ill create a component. > > If it an idiotic thougth to just removed the Bundle suffix from the folders > and have the bundle class itself still be *Bundle.php ? that way it would > make a little more sense compared to the file path for resources ? > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > > > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
