On 1/29/12 9:07 PM, Lukas Kahwe Smith wrote:
Hi,
I think its awesome that we have many people providing feedback in PR's (aka
not only Stof). But just something I want to pass along here is that people
providing the feedback should try and check if the person that send the PR is
new (aka if you have never seen the github nick and can't see it yet listed on
symfony.com/contributors). In that case please also add a personal note with a
link to for example the CS or some other commentary that otherwise you think
its a good addition etc. Don't forget the feeling you had back when you send
your first OSS contribution. We run the risk of scaring these new contributors
off if within 10mins they get 10 notifications with 2-5 words telling them in
dry words what they did wrong. Especially for CS fixes, we of course care that
this stuff is corrected, but I have yet to find a developer that couldnt adapt
his code contributions to fix a code style. In other words learning the CS is a
trivial process, what is more relevant if the cont
ribution helps us get better.
I would like to add another thing: let's not make CS remarks before we
are sure that the code is in good shape to be merged.
Fabien
regards,
Lukas Kahwe Smith
m...@pooteeweet.org
PS: Just to clarify, this is not directed at any one particular, since most of
us I think have been guilty of the above on a few occasions. And of course most
of us has already done their share of helping newbies. I just wanted to bring
this topic to the general attention once again :)
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to symfony-devs@googlegroups.com
To unsubscribe from this group, send email to
symfony-devs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
