Comment #29 on issue 1598 by mattpap: New polynomials manipulation module http://code.google.com/p/sympy/issues/detail?id=1598
> I have a patch for consideration...factor() in polytools should not be > returning > two arguments I already fixed that in polys3 and written tests. > Also, I made a gcdfactor function for simplify and showed it being used in > Add.as_numer_denom(). That is a separate commit in the same branch. What > do > you think? terms_gcd() function (equivalent of gcdfactor()) is available in polys3, so you don't need to reimplement its functionality. The rest of the patch seems OK. The only question is if using non-core functionality in Add.as_numer_denom() is the right thing to do. I expect as_numer_denom() to be as fast as possible and not necessarily returning optimal results. We have fraction() for "magic". But if terms_gcd() (or gcdfactor()) is not slowing down as_numer_denom() too much then why not, at least we cut down on cancel() in this case. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en.
