Comment #68 on issue 1694 by nicolas.pourcelot: solve has many issues with
fractions
http://code.google.com/p/sympy/issues/detail?id=1694
Thanks for you reviewing it so fast.
I prefered when you used numbers in your comments, it was easier to refer
to.
A few comments/questions :
"these lines are uncovered"
My English is not so fluent, so I suppose that "uncovered" means "not
covered by any test" ?
" if flags.get('warning', False):
print("Warning: solution %s could not be verified." %sol)
"
Do you know I may test such a thing ? Using docstring ?
"I don't understand why Add is left out of the first test where the
expression is turned into a fraction."
If included Add initially, but it complicated a lot some solutions which
couldn't be easily simplified then, and so some tests failed.
Once again, my goal wasn't to produce a perfect patch which fix every
single solve() issue, but a patch which fixes some while not introducing
any regression...
"*More significantly*, this portion
of code should not be added there. It should either be factored out
as a separate function, e.g. _handle_rational(eq, symbol, flags), or
tucked into the existing GS_* portions. Once you start doing this, the
whole purpose for which guess_* was added is defeated. (And if you see
my 1766 branch, my solve() routine, you will see that I know something
about what it looks like as you move away from that structure ;-))."
I may refactor this into guess_solve_strategy() indeed.
I'll have to introduce new GS_MUL, GS_POW and GS_FRAC new strategies.
I totally agree with your last comments.
Thanks again. New version will follow in a few hours...
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
