On Tue, Feb 15, 2011 at 9:38 AM, Aaron S. Meurer <[email protected]> wrote: > Hi. > > On Feb 15, 2011, at 10:28 AM, Felix Kaiser wrote: > >> Hi, >> >> a) If I reviewed a pull request, can I push it in directly or should I let >> one of the core devs do it? > > Yes, please do. You can especially push stuff in for the webpage (because > that isn't going to "break any tests". For the main repo, as long as you are > sure that the tests all pass and that there are no objections from anyone, > you can also do so. Pushing stuff in when it has been reviewed really helps > us, so this is actually encouraged (otherwise we get behind). > > So basically, there are three main things to do before pushing (am I > forgetting anything anyone?): > > 1. Make sure all tests pass (if it is part of the main repo; for the webpage, > make sure everything looks good and also that the pages are built). Do this > for the merged/rebased version to make sure that that didn't introduce any > errors. > > 2. Make sure that all content has been reviewed (for example, make sure that > the person didn't push in a new commit to the branch for review that you > didn't notice). > > 3. Make sure that no one else has any objections to the branch. Everything > is based on consensus, so until one is reached, the branch cannot be pushed > in.
4. QA: That all new methods/functions/classes have some doctests showing how to use that. And that all new functionality is tested. I would say that once it gets reviewed (by someone else than the author of the patch), then people with push access should use their judgment and ask "if I push this in, would Aaron object to it?". That's pretty much it. So if it is a simple patch, and Aaron has gave ok to similar patches in the past, it's pretty much safe to push this in. If it's some big branch, for example the new quantum stuff, my own judgment told me to have an ok from aaron in that case. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
