Hi, here are my opinions. If you look here:
https://github.com/sympy/sympy/pulls you can see, that most people have only 1 or two pull requests open, and Chris has 10. Those are the facts. Now we would like the number of open pull requests to be merged in a reasonable time frame. I don't believe in some formal structure like (1 day wait period or something), but I do believe that requiring a review (of anybody else but the author) is good (even if it means I just tell let's say Luke across the table in the same room to review it for me... publicly of course). Ultimately, the one who pushes it in (most frequent sympy developers have push access), must make sure, that the project leader (e.g. Aaron now) is ok with the pull request getting in. And it is then all about building trust and communicating with Aaron. I think that this model works excellent, and it is I think very similar to what Linux uses as well. And it scales well too. Now, from the perspective of me, writing a patch and wanting to get it in ---- I think the best process is the following: 1) send the pull request 2) wait a bit, if it gets reviewed soon 3) ping relevant people to look at it --- use any communication channel (e.g. IRC, sympy-list, for big patches even the main mailinglist, personal email, phone calls, ...) 4) concentrate on one or two pull requests only, and once the review stalls, ping relevant people again (even private email) 5) get it in, and move on to the next pull request The point 4) means to really stick to it and get it done, and also be persistent, until all parties agree with the pull request and it can go in. It helps if the pull requests are smaller --- if they contain lots of patches, and especially if it changes lots of (sometimes unrelated and potentially disputable things), it simply takes longer to review, because people are not sure if the patch is ok and it won't break anything in sympy. And finally, from the point of me, as a reviewer: I have limited time to review patches, but I do. I go to the pull requests from time to time and try to review all patches, and run tests and so on. Most of sympy developers do. However, sometimes I don't know which pull request is the highest priority. So I simply try to choose some that I think are highest priority. And it would greatly help, if let's say you Chris wrote me an email saying --- Ondrej, from my 10 patches, concentrate on this one (/link/) and get it in. After it is in, we move to the other ones. So at the end, my suggestion: Chris, pick one patch, that you think is the most important from your 10, and send me a private email (or even on the list, so that other people can join) and let's get it in. We will only concentrate on that one patch, and you'll see that it will get in. Then we'll move to the next one, and eventually it will get all in. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
