I agree with Chris that you should submit it as a pull request. One thing that will need to be done before it is merged is that you should add doctests (examples) to all the docstrings, and also some regular tests in a test_gaussopt.py file. But you can go ahead and submit a pull request even before you do this, to start receiving more feedback on the code.
Another thing: I'm not sure how imports work in the physics module. For example, the __init__.py file seems to import only a few things, and appears to not be up to date. This probably needs to be cleaned up. One thing that you can do is to define __all__ at the top of the module so that when someone does "from sympy.physics.gaussopt import *" it will import all the right things, and none of the internal variables or classes. Aaron Meurer On Thu, Sep 22, 2011 at 7:34 PM, Chris Smith <[email protected]> wrote: > On Fri, Sep 23, 2011 at 6:09 AM, [email protected] > <[email protected]> wrote: >> In most (but not all) cases the arguments are directly passed to the >> constructor of matrices. I suppose that then sympification is not necessary. >> Am I right? After all I have type(Matrix( (1,) )[0]) == numbers.One. > > Yes, you are right. So if the numbers are getting sent to matrix they > don't need to by sympified. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
