Hi, I've added doctests to every function or class. As the module is very simple there are no internal classes, so there is no need for __all__. I'm making a pull request.
https://github.com/sympy/sympy/pull/617 Stefan 2011/9/23 Ondřej Čertík <[email protected]> > Hi Stefan, > > On Thu, Sep 22, 2011 at 6:42 PM, Aaron Meurer <[email protected]> wrote: > > I agree with Chris that you should submit it as a pull request. > > Absolutely, I would love to have your module in sympy as well. > > > > > One thing that will need to be done before it is merged is that you > > should add doctests (examples) to all the docstrings, and also some > > regular tests in a test_gaussopt.py file. But you can go ahead and > > submit a pull request even before you do this, to start receiving more > > feedback on the code. > > > > Another thing: I'm not sure how imports work in the physics module. > > For example, the __init__.py file seems to import only a few things, > > I think that we just left most of the things in the python files > themselves (not importing them in __init__.py), until things settle > some more about what things should be imported and how. I think that > the best way is to import the most usable things in the respective > modules, that is for the wigner module: > > from sympy.physics.wigner import * > > or quantum module: > > from sympy.physics.quantum import * > > and that sympy.physics itself should not import anything. > > > and appears to not be up to date. This probably needs to be cleaned > > up. One thing that you can do is to define __all__ at the top of the > > module so that when someone does "from sympy.physics.gaussopt import > > *" it will import all the right things, and none of the internal > > variables or classes. > > I agree with the __all__ statement. > > Ondrej > > > > > Aaron Meurer > > > > On Thu, Sep 22, 2011 at 7:34 PM, Chris Smith <[email protected]> wrote: > >> On Fri, Sep 23, 2011 at 6:09 AM, [email protected] > >> <[email protected]> wrote: > >>> In most (but not all) cases the arguments are directly passed to the > >>> constructor of matrices. I suppose that then sympification is not > necessary. > >>> Am I right? After all I have type(Matrix( (1,) )[0]) == numbers.One. > >> > >> Yes, you are right. So if the numbers are getting sent to matrix they > >> don't need to by sympified. > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups "sympy" group. > >> To post to this group, send email to [email protected]. > >> To unsubscribe from this group, send email to > [email protected]. > >> For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > >> > >> > > > > -- > > You received this message because you are subscribed to the Google Groups > "sympy" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > [email protected]. > > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > > > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
