On Wed, Apr 4, 2012 at 10:34 PM, Joachim Durchholz <[email protected]> wrote: >>> It's not a definition of "atomic" though. A 50,000-line pull request can >>> have a complete test suite and pass all tests, yet I'd hardly consider >>> such >>> a thing atomic. >> >> >> How about "the smallest production ready"? >> >> I think that's what Aaron meant. > > > Yes, and that's a useful definition for "atomic", but that would mean 5-line > pull requests.
I am more used to seeing "atomic" in conjunction with "commit", rather than a "pull request". Could it be possible to take a route different from trying to explain what a properly-sized commit means in words and instead have the students learn from their own practise? For example, it could be possible for the mentor to watch the student's branch closely for the first week or two and tell the student when the changes which have been done suffice for a pull request. I may be underevaluating the amount of effort required on the mentor's side to achieve this, though. Sergiu -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
