Am 04.04.2012 23:30, schrieb Aaron Meurer:
And if we can get the reviews done
quickly (a pipe dream I know), then it's really not an issue.

I have been planning to do more review work, but it's hard to find reviews where I can be of help. I still have too many blind spots wrt. SymPy's overall structure.

For example, the C class is rather mysterious. Its mechanics can be inferred from the code with some effort, but there's no documentation that explains why it is there, why it is constructed the way it is, or what alternatives were considered and were rejected for what reason (if only "the implementor of the C class got the job done"). So I'd be unable to review the usefulness of a pull request that modifies C, even if I could review it for obvious bugs or too little test coverage.

--
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to