Without getting into the discussion about Basic args, it should be possible to sort the args in a platform independent way. For example, with str or __name__ (str should work unless it's a class that hasn't overridden it, which will have the id in the string).
My concern right now is more about getting tests to pass with hash randomization than with architectural issues, so that we can release. So I'd gladly see some quick fixes to get the tests to pass now, and we can work out a better architecture later. Aaron Meurer On Jun 22, 2012, at 12:06 PM, Sergiu Ivanov <[email protected]> wrote: > On Fri, Jun 22, 2012 at 9:01 PM, [email protected] > <[email protected]> wrote: >> And to get back on topic (FiniteSet and leaving the args stuff aside): >> >> I vote for not sorting and then rewriting the doctest. > > Sounds reasonable, I vote for that as well. > > Ronan, this will result in removal of element_sort_fn, and hence will > address your comment [0]. > > Sergiu > > [0] https://github.com/sympy/sympy/pull/1371#issuecomment-6513085 > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
