On Sat, Jun 23, 2012 at 1:07 PM, Aaron Meurer <[email protected]> wrote:
> On Jun 23, 2012, at 4:03 AM, Sergiu Ivanov <[email protected]> wrote:
>
>> 2. Have FiniteSet sort its elements, just as it does now.  However,
>>   fix that one doctest which puts *two* non-Basic objects in a
>>   FiniteSet to only put *one* non-Basic object.  This will convey the
>>   same message and avoid the dependency on the machine.  Note that
>>   the failures in the doctests now are only due to the fact that the
>>   two non-Basic elements in one single doctests are getting sorted in
>>   different order with respect to each other, while all other
>>   elements always get arranged in the same way.
>>
> I would change it to hold zero non-Basic objects. That way at least
> the behavior won't be documented and we can remove it without much
> issue in the future.

Indeed, that sounds a lot better.

> And by the way, .args doesn't have to be sorted for the printing order
> to be sorted.

Oh!  That changes a lot :-) In that case I guess I'll try a little bit
more to remove sorting from FiniteSet and, should I fail, I'll resort
to the approach discussed in the previous paragraphs.

Sergiu

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to