On Sat, Jun 23, 2012 at 6:19 PM, [email protected]
<[email protected]> wrote:
> I do not know much about FiniteSet and I am not commenting on the
> merits of the solution. Just asking, is there a reason that FiniteSet
> does not rely more on frozenset? For comparison for instance? It
> should not compare .args, it should compare frozenset(args).

That's an excellent question.  Actually, in the commit [0] of the
corresponding pull request I do almost what you say: redefine
FiniteSet._hashable_content() to return the frozenset of the elements
provided at construction.

> And as Aaron said, if it works we can as well accept the current
> solution and fix it later.

I expect both approaches (in the pull requests mentioned in my
previous E-mail) to work :-) If they do indeed work, we can afford to
spend another couple hours deciding which of them would be better to
choose for now, I guess.  Now that there is some code (which hopefully
works), I'd expect it to be much easier to make the choice.

Sergiu

[0] 
https://github.com/scolobb/sympy/commit/45b5aa44738cb3768fb0701958d417fca0e36787

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to