Hi Ondrej, I made a commit. Please have a look at it when you are free.
PR: https://github.com/sympy/sympy/pull/2303 Regards, Thilina. On Fri, Aug 2, 2013 at 1:35 AM, Thilina Rathnayake <[email protected]>wrote: > Hi Ondrej, > > There was a problem with the equation y**2 - 7*x*y + 4*y*z which returned > y = 0 > for the parametric solution. Although the parametric representation is not > complete, > this is ugly. I fixed this by noticing that we can factorize the input > equation and solve > each factor. By this way, We get more simpler solutions. In this case we > can solve > y*(y - 7*x + 4z). > > I will make a commit very soon. > > Regards, > Thilina > > > > On Fri, Aug 2, 2013 at 1:13 AM, Ondřej Čertík <[email protected]>wrote: > >> On Thu, Aug 1, 2013 at 11:26 AM, Thilina Rathnayake >> <[email protected]> wrote: >> > The branch I used to commit code for binary quadratics is already >> merged. >> > Currently I am working in the branch "Diophantine_Equation_Module_II" >> > which I have been using to commit the code for ternary quadratic >> equations. >> > It's not merged. >> > >> > I need to change some code in the binary quadratic equations. So, >> should I >> > commit >> > those changes in the same branch I use to commit code for ternary >> quadratics >> > or >> > start a new branch? This is not a huge issue but making both changes in >> the >> > same branch >> > might be confusing. >> >> I would make a second branch, based on the first one. That way, if you >> want to later >> merge them, you can easily do that. >> >> Is there a reason why we cannot merge Diophantine_Equation_Module_II yet? >> >> Ondrej >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/sympy. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
