Thanks mario for the great job. Let me try your code. Regards, Thilina
On Wed, Jul 24, 2013 at 12:47 AM, Ondřej Čertík <[email protected]>wrote: > Thanks. Should we integrate it into sympy? > > Ondrej > > On Tue, Jul 23, 2013 at 1:34 AM, mario <[email protected]> wrote: > > In the attached file there is a new version of ``descent``; I followed > your > > suggestion about > > reducing the input to the square free part; in this way the lowest > modular > > square root is > > always used; there is no need to use others; so the code in Smart seems > to > > be correct, > > provided the input is reduced to the square free part. > > It is used the fast ``sqrt_mod`` in > https://github.com/sympy/sympy/pull/2307 > > > > > > On Saturday, July 20, 2013 7:40:05 PM UTC+2, Thilina Rathnayake wrote: > >> > >> Thanks Ondrej for putting the link of the PR. I am sorry I forgot to put > >> it. > >> > >> I am really grateful If other's can play with this and give feedback on > >> how this can be improved, > >> especially reports any bugs in the programme. > >> > >> Thanks in advance. > >> > >> > >> > >> On Sat, Jul 20, 2013 at 11:00 PM, Ondřej Čertík <[email protected]> > >> wrote: > >>> > >>> On Sat, Jul 20, 2013 at 11:25 AM, Thilina Rathnayake > >>> <[email protected]> wrote: > >>> > Hi Ondrej, > >>> > > >>> > I am pleased to say that I managed to implement the solutions for > >>> > quadratic > >>> > ternary forms. > >>> > Only thing we have to verify is that whether they are complete. I > found > >>> > one > >>> > incident in the > >>> > current implementation where it returned a partial solution. I added > it > >>> > as a > >>> > different test. I plan > >>> > to implement the algorithm Implemented in MAGMA in the upcoming days, > >>> > and > >>> > also it seems like > >>> > MAGMA's algorithm is faster. So we can make it the main algorithm > used > >>> > by > >>> > `diop_solve()`. > >>> > > >>> > There is one major factor affecting the speed of the algorithm, the > >>> > overhead > >>> > of the function > >>> > `quadratic_congruence()` which solves a quadratic congruence. This > >>> > function > >>> > was also used in solving > >>> > binary quadratic forms also. I found a link to a reference material > on > >>> > the > >>> > problem. > >>> > > >>> > Also the parametric solution returned by the solver would be more > >>> > elegant if > >>> > we could reduce the > >>> > basic solution we found using the `descent()` by the Hozler's > reduction > >>> > algorithm. > >>> > > >>> > These are the area's I am going to focus in the future. > >>> > >>> Very cool, I agree. Thanks for the work, you have done excellent > >>> progress. > >>> I'll try to play with your branch in the next few days. > >>> > >>> > > >>> > (PS - You have already commented in the pull request. Thank you for > >>> > that. > >>> > I'll get to it as soon as > >>> > I finish writing this week's blog post) > >>> > >>> Here is the PR if others would like to comment: > >>> > >>> https://github.com/sympy/sympy/pull/2303 > >>> > >>> Ondrej > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > Groups > >>> "sympy" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > an > >>> email to [email protected]. > >>> To post to this group, send email to [email protected]. > >>> > >>> Visit this group at http://groups.google.com/group/sympy. > >>> For more options, visit https://groups.google.com/groups/opt_out. > >>> > >>> > >> > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > To post to this group, send email to [email protected]. > > Visit this group at http://groups.google.com/group/sympy. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
