I would just start a pull request with the script, so that people can review it on GitHub. You can start fixing the errors in that branch too, but don't add it to the test suite until everything passes, so that it can be merged before you finish.
Yes, there are a few synonyms throughout the code base. A "from sympy import name" will always define a unique name, but several submodules that are not imported with import * use the same names. In at least one case (the dpll code) two functions are intentionally named the same thing. Aaron Meurer On Mon, Oct 14, 2013 at 4:29 AM, <[email protected]> wrote: > I started reviewing the diagnostics and found two things, one that might > need a change and one that very probably needs a change. > > 1) I have seen that some modules are really copies of external code, > slightly adapted so that that code lives inside the sympy module. > Diagnosing import style violations there does not make sense, mostly since > we can assume that these modules have their own (and hopefully working) > import cycle management. > I suspect that mpmath is of that categorie. > What I need is a list of submodules that do not need import checking. Is > it somewhere, or can it be made to exist somehow (AFAIK that external code > is transformed by a script so that could be changed - I forgot which > script that is so if somebody knows, drop a note please). > > 2) The current checking code assumes that there are no synonyms, i.e. that > if a symbol is imported, it's always the same object. It seems that this > is not always the case, I have seen hints of synonyms being used in > printing code. I'm not sure that this is really happening, but I believe > that the import checking code should catch this case anyway. > So what I'm going to do is to make the definers dict distinguish between > synonyms. Unless somebody points out some reason why that would be the > Wrong Thing to Do(tm), that is :-) > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
