Am 15.10.2013 03:59, schrieb Aaron Meurer:
I would just start a pull request with the script, so that people can review it on GitHub.
As soon as the code properly recognizes synonyms. No use reviewing code that's not doing what it should. > You can start fixing the errors in that branch
too, but don't add it to the test suite until everything passes, so that it can be merged before you finish.
Sure thing. Repeating the questions that still stand:
1) I have seen that some modules are really copies of external code, slightly adapted so that that code lives inside the sympy module.
Are there such submodules?
Diagnosing import style violations there does not make sense, mostly since we can assume that these modules have their own (and hopefully working) import cycle management.
Is that correct, or should these modules have their imports checked anyway?
I suspect that mpmath is of that categorie. What I need is a list of submodules that do not need import checking. Is it somewhere, or can it be made to exist somehow
Is there a list of such submodules? Where?
(AFAIK that external code is transformed by a script so that could be changed - I forgot which script that is so if somebody knows, drop a note please).
I think that was bin/adapt_paths, which just adapts a part of mpmath in a hardcoded fashion.
So... probably no list. Is mpmath the only copied-in library? Are there others? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
