Am 25.11.2013 12:28, schrieb Sergey Kirpichev:
Personally, I don't think that it's a big deal to add a hard dependency
to the six module for sympy.
+1
> But currently we tend to include bundled
versions of libraries.
Yes, and I see that as good enough, particularly for such a tiny
dependency as six. We keep control of what six version we're using,
that's beneficial for us.
It's less beneficial for users who integrate some large other Python
modules which might use a different version of six, this could well end
with inconsistent behaviour. I don't think that use case is too relevant
for SymPy though.
> Then, I think - it's better to include from six only
stuff which was needed.
I can see arguments going both ways here.
> Most of code is taken from the six module, I think.
In that case, I think that fact should be clearly visible.
I'd suggest forking out that code from compatibility.py and move it into
a separate six.py, explaining what was taken and what was left out, and
why. That would make it easier to decide when an update would be in
order, too :-)
(We should also mention the origin of the code, in the name of giving
proper credit and such.)
I'm also not too happy about the name "compatibility".
One, it's not where you go looking when you hit a Python 2/3 issue. Had
it been named python3.py, I'd have known where to look. (I bet the
authors of the various version tests weren't aware of it either,
otherwise, we wouldn't see different code for Python version checking
wherever the need arises. ... well, in fact we shouldn't see *any*
explicit Python version checking anywhere.)
Two, it's not where you go looking when you hit an issue that involves
NumPy etc. being either installed or not installed.
I.e. the name doesn't say anything about the topic the module covers.
Oh, and there's another compatibility.py. It covers differences between
dense and sparse matrices.
I think it has the same naming issue, but I guess I'll leave that to the
matrix guys :-)
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
For more options, visit https://groups.google.com/groups/opt_out.
