On Mon, Nov 25, 2013 at 07:51:04AM -0600, Sean Vig wrote: > I think this would be a bad decision. There are several things we have > modified from six, such as the with_metaclass function, having the six > version could throw a wrench into the mix.
Have you ever considered to submit these things to upstream? This code doesn't looks for me to be sympy-specific. > In addition, since we do have some completely custom stuff Any new/different py2 to py3 fixes, for example? > I'd suggest forking out that code from compatibility.py and move it into > a separate six.py, explaining what was taken and what was left out, and > why. That would make it easier to decide when an update would be in > order, too :-) > (We should also mention the origin of the code, in the name of giving > proper credit and such.) > > Pulling the code out of compatibility.py would be similarly bad, as we'd > again be left with 2 locations for compatibility fixes. Make things transparent never ever be bad. This file could be a place to put some imports from the *standard* six.py and to include some 2.x workarounds. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
