I personally don't use PEP 8 style warnings in my editor because I always write code that is PEP 8 compliant, or if I don't, it's on purpose. I do use pyflakes warnings, though, which warn about unused variables and undefined variables. Fixing those is worthwhile, but in my opinion, trying to fix whitespace issues is futile and a waste of time. The pull request will be impossible to keep in a merged state, and will become the source of much bikeshedding. And at the end, of the day, does it really matter if there are one, two, or three spaces between classes and functions?
Aaron Meurer On Sat, Dec 27, 2014 at 6:07 AM, Joachim Durchholz <[email protected]> wrote: > It would be nice to be able to work on SymPy using Eclipse. > > Current state of things is that I'm getting ~50,000 errors/warnings. I tried > cleaning this up a bit with some hopefully uncontroversial changes - fixing > the E30x warnings (too many/few empty lines between class/function > declarations) dropped that number by ~3,000, which is a start but obviously > no more than that. > > I'm considering configuring PyDev to do somewhat less strict PEP-8 checking, > but it didn't work (yet). > Also, this might mean adding a .project file or some other way of helping > people configure their PyDev into usefulness, so I'm not sure what the best > way ahead is. > > My current working mode is to fix one kind of warning at a time, and do a > mega commit for that. This makes it easy to fix those things that can be > fixed in a mechanistic way, and it also makes it easy to review the pull > requests. > On the minus side, the commits can get pretty large, and they touch > everybody's work, so they should not sit unmerged for very long. > > Thoughts? Opinions? > > Regards, > Jo > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/549EAF02.9070806%40durchholz.org. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6JvOwR6yYLNeLJSU8K1%3DN9gVZA3mUhoeQE%3DL8xBixd7MQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
