Am 27.12.2014 um 20:57 schrieb Aaron Meurer:
I personally don't use PEP 8 style warnings in my editor because I
always write code that is PEP 8 compliant, or if I don't, it's on
purpose.
That may be the case, but I have seen several pieces of code where PEP8
compliance wasn't given more than a passing nod. Obviously not your
code, I assume (though I doubt that being PEP8-compliant in the way you
describe would border on the superhuman).
Still, other people will not apply PEP8 in the same way as you do.
Actually I thought of myself as pretty PEP8-compliant, but a quick check
revealed that I'm nowhere near that.
From that, I'm taking home that claims of compliance to any ruleset
need to be validated (actually just like any claim).
I'm also taking home that at least for people new to Python, running
pep8.py on a few occasions will help them write more idiomatic Python
code, even if only on a very superficial level. It's still valuable
because it will take stylistic matters off the mind of the more
experienced Pythonistas here, because they'll simply say "please run
your code through pep8.py and make sure that no unintentional violations
remain, that makes it easier on my eyes and we can then fix the really
important issues".
> I do use pyflakes warnings, though, which warn about unused
variables and undefined variables. Fixing those is worthwhile, but in
my opinion, trying to fix whitespace issues is futile and a waste of
time.
I can see that point. Actually I have a lot of sympathy for it.
> And at the end, of
> the day, does it really matter if there are one, two, or three spaces
> between classes and functions?
Surprisingly enough, it does.
I did that empty-line correction just as a way to test my new PyDev
installation and see how easy it would be to do any clean-up tasks with
it. I certainly didn't expect any noticeable changes in code quality.
However, when looking at the code, I found it noticeably easier to
navigate it.
> The pull request will be impossible to keep in a merged state,
Not that I'd say "impossible", but yes it would be good to decide quickly.
and will become the source of much bikeshedding.
Not really. The C crowd have their One True Brace Style to bikeshed
about, we have PEP 8.
Though I wouldn't take "bikeshedding" as a "no can do". In fact almost
any project in C land has decided on a specific color for their
bikeshed, and moved on to other issues.
So, yes, bikeshedding, but it quickly passes. Not a serious issue in the
long term.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/549F24E5.3000801%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.
