Hello everybody,
my last comment to the pull request went to /dev/null because of this:
skirpichev locked and limited conversation to collaborators 12 hours
ago
Wow. Locked out without fair warning. No community consensus either.
I know you get to see new sides of people as they get under stress, but
I didn't expect to see this.
I think some kind of repercussion for such entirely inacceptable
behaviour would be in order, but I'll leave judgement to others. I'm
open to discussion in private mail or here on the list.
Fair warning: If this kind of behaviour is considered acceptable by the
project, I'm out of here. Everybody's chance to rid the SymPy project of
that stubborn, nagging Toolforger me ;-)
The discussion is on https://github.com/sympy/sympy/pull/8538 .
For the record, I'm reproducing the rejected comment here on the list.
Regards,
Jo
Am 01.01.2015 um 20:00 schrieb Sergey B Kirpichev:
On Thu, Jan 01, 2015 at 09:33:20AM -0800, Joachim Durchholz wrote:
You can't claim that you're impartial after all.
Why not?
Conflict of interest. Duh.
>> 1) It makes style checking optional.
>
> No, it doesn't. See the pr code.
It depends on whether TEST_PEP is set.
For the local testing case, that's "optional".
TEST_PEP - for travis builds.
Still optional for local builds.
(More precisely: "local command-line uses of bin/test")
I haven't checked whether and where the Travis setup sets that variable.
Then please read the code first.
Irrelevant to the points I'm making.
>> 2) It makes style checking partly optional (check_code_style is run
>> unconditionally, pep8.py conditionally).
>
> Travis runs both pep8 and remaining stuff in the
> test_code_quality.py. And you can do same locally.
Again, that "can" means "it is optional".
No. It is what it is.
Indeed, it is optional. Because you *can* activate it, or not.
Which is bad.
Also, it means that local tests do different thing than Travis tests.
No.
So... local builds use Travis? No?
Local builds have TEST_PEP set? No?
3) It picks the latest version of pep8.py.
That's a known issue. We can disable some checks, or just wait a
little and use next stable release. I don't like first option,
That's fixed already, so that point is moot.
No. That's not fixed yet.
I saw an explicit git hash being used, so I assumed that was for fixing
this problem.
If it doesn't - well, then this still needs fixing.
I see you changed it back to HEAD yesterday.
Is that intended to be temporary, or final?
> E112 and E113 checks looks to be useful for me.
We disagree on that then.
(See above for the reasons why I consider them useless.)
I don't see anything meaningful from you in this sense, sorry.
You never asked about what you didn't find understandable, so I can't
clarify.
We don't use here same pep8 version as your PyDev
environment.
I am currently not talking about my PyDev environment at all.
I'm talking form a command-line user' perspective.
(Getting PyDev to handle SymPy well is going to be a major undertaking.)
Please understand this.
I understood this several days ago.
I assume that you're correct for the Travis builds, but that doesn't
help for local testing.
For local testing we should edit instructions for developers in the
wiki. That's all.
Making tests less automatic in this way is definitely going to be -1
from me.
I've been trying to argue that point, but that didn't convince you;
therefore, I recommend you ask somebody else directly.
> Regarding multi-line function calls, [...]
I mentioned these changes because I was curious whether pep8.py reports
them or not.
Sure, it reports.
Finally. Thanks.
So... the answer to @asmeurer's question is "no, it does not ignore line
continuations". Which means he'll maintain his -1 until that test is
either disabled or (if pep8.py offers that) modified so that it does not
report these lines in their original form.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/54A64AC0.4000102%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.
