On Fri, Jan 2, 2015 at 11:30 PM, Sergey B Kirpichev <[email protected]> wrote: > On Fri, Jan 02, 2015 at 10:19:48PM +0100, Ondřej Čertík wrote: >> I have unlocked the PR (https://github.com/sympy/sympy/pull/8538). >> >> Sergey, if there is ever need for such a thing (I actually didn't even >> know you can lock a PR), please discuss this with me first. > > Ok, I consider two possibilities. Either lock PR, or > close it. I don't think, that other reviewers should go through > unproductive discussion thread. > > Review should be helpful. For example, I suppose, that people > read code (and run, if that's appropriate) before commenting on it. > It seems for me, this is not the case...
Yes. And Joachim admitted that he might have discussed unproductively (in another thread few minutes ago), so I think next time just ask to finish the discussion, since it seems unproductive, and/or bring it to Aaron's attention, as he is ultimately responsible for any code decisions. As Matthew suggested above. > >> not as some kind of community moderators > > Please take into account, that this is my PR. Exactly, *especially* if it is your PR, you need to distinguish between the two hats that you have: 1) the author of a PR 2) having push access and you should not use the power of 2) for 1), i.e. for your own PRs, the best is to behave like if you didn't even have a push access. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVDEmi60KfXiS%3DavODc%2B2NGQwa8wC0o_FUA8Tb1N2xuvPg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
