> > I am pretty sure that builds that time out eventually turn into the
red or gray cross, don't they? They show "Errored" instead of "Failed". Sudhanshu Mishra On Wed, Jun 10, 2015 at 2:10 AM, Ondřej Čertík <[email protected]> wrote: > On Tue, Jun 9, 2015 at 2:31 PM, Sartaj Singh <[email protected]> > wrote: > > I think it's a good idea. +1 > > > > Just a note. Reviewer should be careful with the 'waiting for Travis to > > finish' Label. Sometimes it's just a timeout Error. So, errored build > should > > be kept in mind while assigning the labels. > > I am pretty sure that builds that time out eventually turn into the > red or gray cross, don't they? > > So if we only assign the "Travis to finish" label to yellow statuses, > that should be robust. > > Ondrej > > > > > On 10 June 2015 at 01:27, Ondřej Čertík <[email protected]> wrote: > >> > >> Hi, > >> > >> I've added few labels related to PR: > >> > >> PR: needs more work (author's turn) > >> PR: waiting for Travis to finish > >> > >> and then we can use them in a query. In particular, to only see PRs that > >> > >> * are open > >> * pass all tests > >> * do not have the "PR: needs more work (author's turn)" label > >> * sort by recently updated > >> > >> do: > >> > >> > >> > https://github.com/sympy/sympy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+status%3Asuccess+sort%3Aupdated-desc+-label%3A%22PR%3A+needs+more+work+%28author%27s+turn%29%22+ > >> > >> Those are all PRs that either can be merged or reviewed. If after the > >> review the author needs to do more work, just add the label "PR: needs > >> more work (author's turn)". > >> > >> Then, when you start your reviewing session, start by looking at the > >> PRs where it was author's turn, sort by recently updated: > >> > >> > >> > https://github.com/sympy/sympy/issues?q=is%3Aopen+label%3A%22PR%3A+needs+more+work+%28author%27s+turn%29%22+sort%3Aupdated-desc > >> > >> and remove the label to PRs where the author did the work. > >> > >> I started using this workflow, it seems it is a lot more manageable. > >> Let me know what you think. We should refine this and document it. > >> > >> Ondrej > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "sympy" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an > >> email to [email protected]. > >> To post to this group, send email to [email protected]. > >> Visit this group at http://groups.google.com/group/sympy. > >> To view this discussion on the web visit > >> > https://groups.google.com/d/msgid/sympy/CADDwiVAMnWPw81ow04n9BmAArMYfb1_9EAx5WAFWNLffn1xQAw%40mail.gmail.com > . > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > -- > > Regards > > Sartaj Singh > > > > Mathematics and Computing, > > Indian Institute of Technology, > > Varanasi - 221 005 INDIA > > > > E-mail: [email protected], [email protected] > > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > To post to this group, send email to [email protected]. > > Visit this group at http://groups.google.com/group/sympy. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/sympy/CAC%2BH8-FpuzY_-i4Jn9ON6hm9gj52eezoTVsNE3SzELASDi1WLA%40mail.gmail.com > . > > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CADDwiVD8yN5TGSoGB%2BjKTHUK9NqiE-g%2B%2BEnqcfNh40DU6KnaJg%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAFW_KCSfSgptWanVt7eX4rjRX9bjMDBtoC3Ab4R2kwELkUyVWQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
