On Tue, Jun 9, 2015 at 4:27 PM, Joachim Durchholz <[email protected]> wrote: > Am 10.06.2015 um 00:22 schrieb Ondřej Čertík: >>> >>> That way, each PR is in one (and only one) of the following stages: >>> >>> * tests are in progress (the yellow status) >>> * labelled "PR: needs more work (author's turn)" >>> * labelled "PR: in review" >> >> >> How about calling these: >> >> PR: author's turn >> PR: sympy's turn > > > +1. "Needs more work" tends to look like criticism, and not everybody is > happy to receive criticism.
I agree. Sometimes it doesn't really need more work, just a comment / clarification or perhaps only a final approval/permission/blessing from the author to merge this. It's really about who's turn it is. So that both reviewers as well as authors can see if they need to do anything. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVD%2BWpkeH7HiYNsWoFMHp9BYpPPOkx%3DcYs%3D5kQ6SCYfm7A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
