Some general comments on your proposal: * Sometimes is it hard to understand what you are trying to say in the proposal. Check for grammar, revise text to see if you can explain things in a better way. For section where you are proposing an algorithm explain in it in step by step manner using bullet points.
More specific comments: * Expand on how you'll "connect" solveset and diophantine solver, take an overview of the diophantine solver, study its input and output api, and propose how you'll do the actual "connection". * I don't think your gen solve method is correct, I've written my comments on #10713 and haven't recieved satisfactory answer. * For the time-line you don't need to say "Submit PR/commits in each 3-4 days and make required changes", also you have not mentioned when will your college restart after the summer. On 18 March 2016 at 23:36, Shekhar Prasad Rajak <[email protected]> wrote: > Thanks Aaron for reviewing the application. > For system of non linear equations the format can be similar to `linsolve` > means :` FiniteSet(tuple(solution))` > For trig equations solutions would be in `imageset`. Would there be more > cases ? > These are the good ways, right? > > -- > Shekhar Prasad Rajak. > > On Thursday, 4 February 2016 00:40:34 UTC+5:30, Shekhar Prasad Rajak wrote: >> >> >> Hello, >> my name is Shekhar Prasad Rajak.I want to discuss about Solver and >> Solveset module >> https://github.com/sympy/sympy/wiki/GSoC-2016-Ideas#solvers .I am going to >> apply for GSoc'16, so trying to know >> what sympy community expecting. >> Solveset came to Replace all internal solve() calls >> https://github.com/sympy/sympy/issues/8711 >> So I should focus on Solveset,right? >> I have some questions : >> 1.What are the main problems/issues in Solver and Solveset right now? >> 2.Is Solveset module done?If not,what are the main features, that should >> be added ? >> I have seen Harsh's PR : https://github.com/sympy/sympy/pull/7523 >> It seems, these need some works : >> -functions solvable by LambertW >> -functions that can be recast as polynomials with a change of variables >> this, for example; this can be >> factored out of solve where multiple generators are handled >> -use something like this : >> https://github.com/sympy/sympy/pull/7523#issuecomment-62198981 >> to handle the XFAILed test test_real_imag_splitting1, this will be >> handled in the set module. >> >> 3.This is list of Issues/ Discussions I found. >> >> https://github.com/sympy/sympy/wiki/GSoC-2014-Application-Harsh-Gupta:-Solvers#relevant-issues-discussions-and-references >> but I don't know, whether they are solved or not. >> Issues which are still open in github repo, need solutions. >> There are also links of pdf and research papers, I am not sure whether >> they are implemented or not. >> >> 4.Can we use python library multiprocessing,Synchronization for the faster >> execution?one issue was opened for the same,which is closed now.But it is >> always better to take less time. >> >> >> -- >> Shekhar Prasad Rajak >> > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/2e8df2bd-d472-4fc1-b250-d50389e14dd7%40googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- Harsh Sent from a GNU/Linux -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADN8iupEdmo0LAgCD5OO3Riwr96oN7H--jOpmduDxWyKz_yw4w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
