I tried to follow the steps I proposed in shared docs and https://github.com/sympy/sympy/wiki/Solveset-and-Solver-Discussion#simplified-general-form-for-trigonometric-solution <https://github.com/sympy/sympy/wiki/Solveset-and-Solver-Discussion#simplified-general-form-for-trigonometric-solution>
in this PR https://github.com/sympy/sympy/pull/10898 Right now we don't have much testcase for simplified solution. I changed one testcase which is simplifed one now. >From current master branch : ``` >>> print solveset(cos(x) + cos(3*x) + cos(5*x),x,S.Reals) ImageSet(Lambda(_n, 2*_n*pi + pi/2), Integers()) U ImageSet(Lambda(_n, 2*_n*pi - pi/2), Integers()) U ImageSet(Lambda(_n, 2*_n*pi - 2*pi/3), Integers()) U ImageSet(Lambda(_n, 2*_n*pi + 2*pi/3), Integers()) U ImageSet(Lambda(_n, 2*_n*pi - pi/3), Integers()) U ImageSet(Lambda(_n, 2*_n*pi + pi/3), Integers()) U ImageSet(Lambda(_n, 2*_n*pi - 5*pi/6), Integers()) U ImageSet(Lambda(_n, 2*_n*pi + 5*pi/6), Integers()) U ImageSet(Lambda(_n, 2*_n*pi - pi/6), Integers()) U ImageSet(Lambda(_n, 2*_n*pi + pi/6), Integers()) ``` In the https://github.com/sympy/sympy/pull/10898 ``` >>> print solveset(cos(x) + cos(3*x) + cos(5*x),x,S.Reals) ImageSet(Lambda(_n, _n*pi/6), Integers()) ``` This implementaton may have some defects , but I hope if I get more testcase then I can improve this PR. Please review once. -- Shekhar Prasad Rajak On Thursday, 4 February 2016 00:40:34 UTC+5:30, Shekhar Prasad Rajak wrote: > > > Hello, > my name is Shekhar Prasad Rajak.I want to discuss about Solver and > Solveset module > https://github.com/sympy/sympy/wiki/GSoC-2016-Ideas#solvers .I am going > to apply for GSoc'16, so trying to know > what sympy community expecting. > Solveset came to Replace all internal solve() calls > https://github.com/sympy/sympy/issues/8711 > So I should focus on Solveset,right? > I have some questions : > 1.What are the main problems/issues in Solver and Solveset right now? > 2.Is Solveset module done?If not,what are the main features, that should > be added ? > I have seen Harsh's PR : https://github.com/sympy/sympy/pull/7523 > It seems, these need some works : > -functions solvable by LambertW > -functions that can be recast as polynomials with a change of variables > this, for example; this can be > factored out of solve where multiple generators are handled > -use something like this : > https://github.com/sympy/sympy/pull/7523#issuecomment-62198981 > to handle the XFAILed test test_real_imag_splitting1, this will be > handled in the set module. > > 3.This is list of Issues/ Discussions I found. > > https://github.com/sympy/sympy/wiki/GSoC-2014-Application-Harsh-Gupta:-Solvers#relevant-issues-discussions-and-references > > <https://github.com/sympy/sympy/wiki/GSoC-2014-Application-Harsh-Gupta:-Solvers#relevant-issues-discussions-and-references> > but I don't know, whether they are solved or not. > Issues which are still open in github repo, need solutions. > There are also links of pdf and research papers, I am not sure whether > they are implemented or not. > > 4.Can we use python library multiprocessing,Synchronization for the faster > execution?one issue was opened for the same,which is closed now.But it is > always better to take less time. > > > -- > Shekhar Prasad Rajak > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/87c2e6a5-fbaf-4d9b-bf65-c91366abf968%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
