On Tue, 16 Mar 2021 at 09:10, Marco Antônio Habitzreuter <[email protected]> wrote: > > Hello folks. I hope you and your families are doing well. > > I'm a physics undergraduate in my final semester. I have been using Sympy for > the last 6 months or so, after having some good experiences with Numpy to > analyze experimental data. Before that, most of my coding was in C. It has > been an extremely useful tool and my undergraduate final thesis would not be > possible without it. Thank you for this amazing work! > > With the intent to give back to the community, I looked at the open issues to > see if there was something on which I could work. This caught my attention: > https://github.com/sympy/sympy/issues/18348. There is a PR refactoring the > code for exact ODEs which seems abandoned at > https://github.com/sympy/sympy/pull/18887. Would it be okay if I tried to > finish it?
Yes please! When continuing an existing PR by another author it is important to keep the note of who wrote what intact in the git commits. I would checkout the branch of the other contributor and rebase it to master and then add my own commits on top. Potentially though it is easier just to manually copy the diff and make a commit that uses Co-authored-by to reference the original author: https://stackoverflow.com/questions/7442112/how-to-attribute-a-single-commit-to-multiple-developers Oscar -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAHVvXxRTapxpKA3ysr0RpgWcFoDMLke3SHTR6iYmOnS7x2%3DGaw%40mail.gmail.com.
