Oscar, > When continuing an existing PR by another author it is important to > keep the note of who wrote what intact in the git commits. I would > checkout the branch of the other contributor and rebase it to master > and then add my own commits on top.
I was able to rebase and get that code working in my fork. About the NotImplementedError you discussed about [0]: if I understand corretly, it was added in [1] to solve [2] due to the lack of derivative at a point as open in [3]. The workaround was necessary because the doctest for ode_1st_homogeneous_coeff_subs_dep_div_indep was failing. Weirdly, I removed the try/except from master and the doctest passed. Maybe something changed along the way which made this unnecessary? I couldn't think of an example where the try/except would be required. [0] https://github.com/sympy/sympy/pull/18887#discussion_r399648142 [1] https://github.com/sympy/sympy/pull/278/ [2] https://github.com/sympy/sympy/issues/4624 [3] https://github.com/sympy/sympy/issues/4719 -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CACTqkX2ixk9QZA4T%3DvVC%3DQ0-RPbqWnrKW8L5BYZi26-geXEDUA%40mail.gmail.com.
