Re: Posted pseudo Release Candidate

[Asankha C. Perera]

Ant Great feedback indeed!  :-) I addition to Paul's comments mine are as below.. could you concentrate on the items in bold BUILDING.txt is out of date - describes mvn v1 and this file should only be included in the src distro not the binary distro. Done Do we really need a DISCLAIMER file still, i think all the required incubator disclaimer is in the NOTICE file now I think we do need this.. check this... -> http://incubator.apache.org/guides/branding.html#disclaimers How about moving docs/release_notes.txt to the top level directory and renaming it to RELEASE_NOTES (and updating it!) +1 will try do this .. please do update this if I miss something or if you want to add anything In docs, are sample_103_1.txt and sample_103_2.txt old unused files that could be deleted? No these are referenced by the Synapse_samples.html and contain sample messages in transit through Synapse In Synapse_Samples.html in the overview section how about another sentence describing why we use our own standalone Axis2 server for the samples I will try to update this if I get the time.. else if you get a chance, please do so Is there anyway the sample axis2 server could have all the sample services pre-deployed by default instead of having the user run ant to build and deploy each sample service? Well.. not right now.. as some samples depend on Rampart etc, and this has become an issue as Rampart MAR is over 3MB! Seems like it will not reduce in size in the upcoming release.. so we are shipping only one copy of rampart.mar and ask the users to copy it to the repositories used by the samples. Hence we cannot ship pre built sample services The userguide is a bit out of date, for example the installing extensions section, and it duplicates some of whats in the extending_synapse and config language guides Paul will take this one as per his email The lib dir includes some (maybe?) unnecessary jars:  - ant-1.6.5.jar removed  - avalon-framework-4.1.3.jar dependency reported by commons logging - so lets leave it for now as its tiny  - annogen-0.1.0.jar required for axis2  - junit-3.8.2.jar removed from dist  - servlet-api-2.3.jar removed  - synapse-incubating-samples-0.90-SNAPSHOT.jar Required for the samples as it contains the Rampart password callback class - this is a tiny JAR so I recommend that we keep it here for now I have also removed the following now: commons-fileupload commons-io geronimo-spec-activation-1.0.2-rc4.jar geronimo-spec-javamail-1.3.1-rc5.jar geronimo-spec-jms-1.1-rc4.jar The Axis2 dependency is set back to axis2-1.1.jar instead of its pieces like we always used to do. (and this should take away one of the POM errors with axis2 we encountered earlier with M2 - the reason for going into the pieces was since the above jar was missing in the maven repo earlier :) I've found a bug in the script mediator which requires a 1 line change to fix and another testcase method to validate, i'd quite like to get these into 0.90. +1 Sample 8, the xslt transform sample repository\conf\sample\resources\transform\transform_back.xslt includes SOAP envelope and body tags in the response so the resulting SOAP msg has a soap body that contains soap envelope and body elements. To cope with this the modules\samples\src\main\java\samples\common\Util.java and modules\samples\src\main\java\samples\common\Util.java files have code to skip over these nested elements. Please do fix this if you can.. I will do so if I get the time... i've a _javascript_ version of sample 8, fine to leave this till next release but if there's some time i could get this in to this release Sure, would be great to have this.. also a section of documentation about the JS/script mediator in the samples would be great The src distro includes some eclipse artifacts - the .settings directory in modules\core, modules\extensions, and modules\samples I have specified that these if any should be excluded now.. but I think its a best practice to build a release from a fresh checkout - to ensure that any old files or IDE files will not remain anywhere The src distro includes some log files in modules\core\logs and modules\extensions\logs directories. Fixed.. make sure to delete these form your existing checkouts if they exist what is the text.xml file in modules\core? This is a dead file and should not exists any more on a clean checkout and build... please delete on existing checkouts How about renaming the 'src' directory in the src distro to something else, maybe 'distribution'? I'm ok.. but I guess maybe after we get the other stuff sorted out.. thanks asankha --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]