On Wed, 2008-01-16 at 09:02 -0500, Richard Alimi wrote: > From my personal standpoint, I just really care that the code is clean and > readable. I understand that the term "readable" is subjective, but someone > shouldn't have to sit there for an hour trying to figure out what a single > function is doing :) > > Another thing that I always try to do before a commit to SVN is be sure that > the code at least compiles, especially if its under /trunk. Whether it works > or not is another story, but someone should be able to take it out of SVN and > build it without errors. This is a bit different when it comes to Python > where some errors (i.e., some undefined variables) aren't flagged until the > interpreter hits that line of code, but the interpreter should still be able > to load the files and start running them. >
I would agree these are the two most important things to consider. svn is obviously meant for active development in code, but it's just polite to make sure something builds before committing it. Probably not to my ridiculous level though, I've got this bizarre habit of re-testing the build after changing a README :) Mark ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ SynCE-Devel mailing list SynCE-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synce-devel