On Fri, 2008-05-16 at 22:33 +0100, Dr J A Gow wrote:

> > This is fairly crack-addled in many ways. Easy to illustrate with a
> > single value from the file: 
> 
> Thank you. Just for the record I do not, and never have, used crack.

Just a turn of phrase :)

> I agree that leaving the defaults uncommented in the XML is probably not
> a good idea from the point of view of user upgrades. I'll change this in
> the SVN tree tonight. It's a simple change, all that is needed is to
> comment out the defaults.
> 
> > Everyone who's already using
> > synce will have a ~/.synce/config.xml . We can't make synce's
> > installation routine edit that file, that'd just be horrible. So anyone
> > who's already used synce is basically stuck with all the default
> > configuration values that happened to exist whenever they first
> > installed synce. Forever. 
> 
> Err, no. Not forever. This file is read at _runtime_. Nothing is preventing
> a user, (or any other program for that matter) from editing that file. That
> is why I used XML for the format - many programs can sensibly handle this
> format.

Yes, obviously, I meant _without manual intervention_. But no point
belabouring the issue, you fixed it. :)

> > Whether we create ~/.synce/config.xml by default or not is essentially a
> > moot point. We may as well, because it aids discoverability, but even if
> > we don't, everything would work. (As a corollary, sync-engine should not
> > fail to run if no user configuration file exists and it can't copy the
> 
> It should not fail to run. Sync-engine will run just fine using sensible
> defaults without requiring a ~/.synce/config.xml. I do not know what the
> packages do, but the development tree copies the file from a location in
> the tree itself, so it should be guaranteed to be there as part of the
> install. If the packages do it in a fashion where it can break, this needs
> to be addressed.

It's an unnecessary failure case. Sure, it indicates something wrong
with the packaging / user installation / whatever. But why fail when you
don't have to? There's no reason that sync-engine should refuse to run
just because it can't create a config file it does not, strictly
speaking, need. I think it's a decent principle to never fail to run
unless you actually *can't* run...

> If it fails, it is because the sync-engine install is broken. That file
> should be there as part of a complete sync-engine install.

Sure. But as I said, it's just not necessary to fail that hard. :)
-- 
adamw


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel

Reply via email to