On Thu, 2009-12-03 at 19:31 +0100, John Carr wrote: > On Thu, Dec 3, 2009 at 5:19 PM, Mark Ellis <m...@mpellis.org.uk> wrote: > > On Thu, 2009-12-03 at 17:26 +0100, Adam Williamson wrote: > >> On Thu, 2009-12-03 at 10:54 +0000, Mark Ellis wrote: > >> > > The dirty patch, the thing of legends. It exists in SVN here: > >> > > > >> > > http://synce.svn.sourceforge.net/svnroot/synce/trunk/patches/usb-rndis-lite-samsung.patch > >> > > > >> > > As you can see, i force debug on because i have no idea whether the > >> > > patch is sane or not and i want all the debug info i can get. The > >> > > reason I consider it dirty is that it needs the rndis_get_in_endpoint > >> > > function which is called every time something calls rndis_command. > >> > > Ideally that should run once when the driver loads for a given device, > >> > > but i felt like i was being too invasive when I started doing that and > >> > > whimped out. > >> > > > >> > > The patch exists through careful comparison of the deprecated user > >> > > mode and the current kernel mode implementations of usb-rndis, the > >> > > poking of an INT IN endpoint being the only difference i found. > >> > > >> > Yes, it's still lurking in the background :) > >> > > >> > I'm casting for comments, I've had quite a few cases where this has > >> > solved a connection problem, and I'd love to get it upstream. While I > >> > can see what it's doing though, I can't _really_ see what it's doing. > >> > I'm tempted to just take it as is to the usb guys and see what they > >> > think, but wanted to throw it out to you guys first. > >> > > >> > Help ! > >> > >> don't ask me, you're the one who wrote it =) > >> > > > > Not me, John's the culprit :) > > > >> seriously, I know practically zip about the code/hardware side of this > >> stuff, I am not a hacker. All I've ever worked on is the packaging. So, > >> um, sorry, but I've no clue. > >> > > > > No worries, you were just vaguely involved the last time this came up. I > > don't know anything about the device driver side either (: > > > > Mark > > > > All i remember is examing the user space version of the driver and > noticing it had an extra poke that the kernel side didnt have, i then > tried to hack a similar poke into the kernel driver and came up with > that patch which *seems* to work for some devices, but i cant explain > why it works. > > John
Ok, I'll take it to the usb kernel guys when I get a chance and see what they think. Thanks John. Mark
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________ SynCE-Devel mailing list SynCE-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synce-devel
