http://bugzilla.moblin.org/show_bug.cgi?id=3604
--- Comment #5 from pohly <[email protected]> 2009-09-01 00:20:03 --- (In reply to comment #4) > However, the root cause is to store password in keyring. We have to write a > new > class to derive from EvolutionSyncConfig to keep config tree away from > keyring. > For EvolutionSyncConfig is used to hold all properties including original > settings and new settings in command line on the fly and configuration and > then > is flushed to files. In this way, we have to check 'password' property many > places in EvolutionSyncConfig for it operates config tree heavily. Any > suggestions? If I may paraphrase: the problem with setting and copying the password in the command line is that it is just a normal string value, like for all the rest of the properties. The command line doesn't even know that special treatment might be needed for "--sync-property password=foobar". So the question becomes: in which cases should it be treated specially? I suppose the answer is "whenever a password is written and the user wants keyring usage". Your current patch gets that right, so let's see whether we can leverage that. Can we add a UI operation that is complementary to askPassword()? savePassword()? The config system could call it whenever it has a password value which needs to be stored. If the UI saves the value or the value was "-" to start with, then the config itself saves "-". One problem which might also need changes in askPassword() is the amount of information provided to the UI about the password. For the main "password", the server URL is needed as auxiliary information. Perhaps the functions should get access to EvolutionSyncConfig and (if applicable) the EvolutionSyncSourceConfig so that they can extract whatever property they need? -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
