http://bugzilla.moblin.org/show_bug.cgi?id=3604
--- Comment #11 from yongsheng zhu <[email protected]> 2009-09-03 18:39:16 --- (In reply to comment #10) > * please remove Copyright (C) 2005-2009 Patrick Ohly <[email protected]> > from the new files ok, I'll do it. > * askPassword should not access the keyring unless told to do so. > The reason is that this may trigger dialogs about unlocking the > keyring or granting access, which is not desirable unless the > user wanted that. so you want to use 'checkPassword' instead, right? Use this to check password in the keyring? If no, then askPassword, right? > * How does the code handle non-HTTP server passwords? I don't see > any kind of check for that in the code. getServerUsers() seems > to assume that it will invoked only for the "password" property > in the main config.ini. That's not the case. Most likely you > have to add more parameters to askPassword and savePassword > to handle the other cases, because the "description" string > doesn't help. I've added 'ConfigNode' into the parameter list. For non-HTTP server passwords, such as source related password 'evolutionpassword', source config will also be transferred.If this is not enough, then I think it could add a string list in the parameter list. I learned from your previous mail that you prefer to let ConfigUserInterface to access EvolutionSyncConfig and SyncSourceConfig? If yes, I'd like to make them inherit from one same base class to make interface clear? > * Don't add "extern" statements in .cpp files. That belongs into > header files included by users and implementors of these items. ok, then I'll add "extern" statements in the "SyncEvolutionConfig.h" > * Why is the branch with 're-write the password value with a string "-"' > commented out? This is necessary. Because I've moved this to config system 'PasswordConfigProperty'. If password is saved by UI, then config system saves its value by '-' because it knows saved password's name and more detailed information instead of UI. See your previous comments: If the UI saves the value or the value was "-" to start with, then the config itself saves "-". > * By putting CmdlineSyncClient.cpp into libsyncevolution, the core > library still depends on the GNOME keyring libs. The code must go > into the syncevolution binary. Use a virtual factory method to > customize which class is created by the SyncEvolutionCmdline. A good suggestion. I'll also move these files out of 'core' directory to make it clearly. > * I don't understand why overriding the flush() method is necessary. Yes, I also hesitate about it for there are 2 choices. If no flush, then user needs to call 'savepassword' explicitly. If invoking this function in the flush method, then password saving will be done automatically. In a word, I have no inclination. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
