http://bugzilla.moblin.org/show_bug.cgi?id=8049





--- Comment #4 from pohly <[email protected]>  2009-11-23 01:57:29 PST ---
(In reply to comment #3)
> If that's true, I think current 'reports' or its key could not match
> requirements, since it has an assumption: reports are belonging to one
> configuration.
> Two solutions: change data struct of 'reports', or add configuration name info
> in its key. I'd prefer the latter.

Me too.

The current format description is:

        <doc:doc><doc:description>The array contains report dictionaries. The
dictionary keys are generated by joining a list of hardcode strings and report
categories. The separator is the charactor "-". The list of strings is:
"source", "[source name]", "stat", "[ItemLocation]", "[ItemState]" and
"[ItemResult]". The dictionary values are directly converted from numbers in
sync reports. The value will be "0" if there is no data in sync reports.
        </doc:description></doc:doc>

I find this description hard to understand. [source name] is obvious, but what
is [ItemLocation], [ItemState], [ItemResult]? This needs to be specified here.
How are these values concatenated to form a key? A Backus-Nauer description of
the key strings would be useful.

The last sentence could be misunderstood. It could be read as "the hash will
contain a value 0 if there is no data in the sync report", which is the
opposite of the current implementation. I suggest to rephrase as "entries not
explicitly set otherwise in the hash have the value zero".

-- 
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to