http://bugzilla.moblin.org/show_bug.cgi?id=8049
--- Comment #24 from pohly <[email protected]> 2009-12-07 03:47:15 PST --- (In reply to comment #23) > so I'll add 'peer name' 'context info' in the LogDir and do these matches in I'm not sure I follow here. Note that SyncConfig already has code to turn a "config" name into "peer" and "context". See normalizeConfigString() and splitConfigString(). > Another issue is that is it ok to put these matches in the LogDir or in the > SyncConfig? For the LogDir, it is in the charge of parsing and encoding dir > names and doing the matches. However, for the sematics of peer and context, > current the logic is described and written in it. LogDir should deal with a "logdir" setting (taken from a SyncConfig) and a peer name, nothing else. > > > 3) add second info in the dir name for accuracy. > > > > I don't understand this. > Dir name is encoded in the 'peername-year-month-day-minute', I want to add a > 'second' info. so it will be encoded in 'name-year-month-day-minute-second'. > The root cause is that logs of different peers might be sorted together by > their creation time. It is possible that two logs are generated within one > minute. I don't think this is necessary. It would just make the directory names longer without any gain in the majority of the cases. To ensure strict ordering of directories, it would be better to use the existing "append sequence number": instead of checking that no directory with the chosen 'peername-year-month-day-minute', check that no other directory has the same 'year-month-day-minute'. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
