http://bugzilla.moblin.org/show_bug.cgi?id=8049
--- Comment #31 from yongsheng zhu <[email protected]> 2009-12-08 17:02:29 PST --- (In reply to comment #30) > Merged. > > Just one minor nit-picking: > - // strip trailing slashes, but not the initial one > - size_t off = logdir.size(); > - while (off > 0 && logdir[off - 1] == '/') { > - off--; > - } > - m_logdir = logdir.substr(0, off); > + m_logdir = boost::trim_right_copy_if(logdir, boost::is_any_of("/")); > > Doesn't that mean that "logdir=/" will be reduced to "logdir="? The old code > was careful to avoid that. Never mind, this wasn't worth the extra lines. yes, you are right. If needed, I think we can add a 'if' statement to judge this. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
