On Mo, 2011-01-31 at 05:23 +0000, Ville Nummela wrote: > I added support for NetworkManager to syncevo-dbus-server. There are two > commits for this on my clone of the syncevolution repository > (http://meego.gitorious.org/~vige/meego-middleware/viges-syncevolution). > The commit ids 02cae38c and 8e3d7b98 are the relevant ones for this.
Looks reasonable, works as promised :-) Thanks a lot. I'll cherry-pick those for "master". I like to keep a linear history on the master branch, that's why I don't just merge branches. We debated the pros and cons a while back here, that's what we settled on. > There are also my changes for the sync-ui, which add the possibility to > change the sync interval from the gui. That one is a bit more problematic. Do we really want to expose the user to the internal text format? Some kind of slider would be better IMHO. The empty string field also doesn't tell the user that there is already a default set, so it looks like he has to choose something, without any guidance. The original issue wasn't so much about "let users choose an interval" but "provide feedback on how auto sync works"; following that logic, showing the default would be more important then letting the user override it. The sync UI doesn't have a way to determine the built-in default (30m), so we would have to duplicate that information - not nice, but the best that can be done at the moment without extending the D-Bus API. See http://bugs.meego.com/show_bug.cgi?id=535 I also had a more practical problems: I typed "10". After that, adding any additional character causes the field to loose focus. I also see that the UI does a SetConfig() call with these preliminary values. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
