On Mi, 2011-12-21 at 14:17 +0100, Chris Kühl wrote: > Overall it looks like it makes sense.
Good. I already went ahead and have a working implementation now, too. > A couple questions though. > > * Where would you be using g_child_watch here? I'm assuming it would > be set up internally in ForkExecParent and then trigger the OnQuit > signal. Right. > * Should the forkexec argument set opt_fork_exec rather than opt_server. Yes. > * Is there a way to avoid passing in the MainLoop? Hmm, yes. After looking at the current implementation I see that the loop is never actually used. The *context* of the loop is used at one point, and NULL would be valid for that. Even that could be avoided by using the default context. I'll remove all of that until there is a need. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
