On Fri, Mar 9, 2012 at 8:05 AM, Patrick Ohly <[email protected]> wrote: > On Fri, 2012-03-09 at 00:52 +0100, Chris Kühl wrote: >> On Thu, Mar 8, 2012 at 7:16 PM, Patrick Ohly <[email protected]> wrote: >> > On Thu, 2012-03-08 at 18:58 +0100, Chris Kühl wrote: >> >> On Thu, Mar 8, 2012 at 6:23 PM, Patrick Ohly <[email protected]> >> >> wrote: >> >> > On Thu, 2012-03-08 at 17:18 +0100, Chris Kühl wrote: >> >> > 6c9a05a9db72f001d9834d2d24ac589f48fc5798 >> >> > >> >> > dbus-server: Run sync sessions in separate processes >> >> > >> >> > ... >> >> > >> >> > Sessions are separated into SessionResource and Session classes. A >> >> > SessionResource instance resides in the server process and serves as >> >> > a >> >> > proxy to the Session instance which is in the child process. >> >> > >> >> > This naming seems rather arbitrary to me. Why call it "Resource" and not >> >> > something like "Stub" or "Proxy"? >> >> > >> >> >> >> Yeah, I'm not 100% happy with the naming either. They are subclasses >> >> of Resource so it was the obvious choice. Renaming is not a problem >> >> but I'd rather get finished with the more substantive changes needed >> >> to complete this before doing that. >> > >> > Everything that minimizes the number of changes that I need to look at >> > helps. >> > >> >> It actually increased the changed line count. :( > > I can see how it might do that. But it did reduce the number of chunks > from 152 to 130. >
Yeah, the session and connection files in the helper are quite a bit larger than those in the server. >> I've gone ahead and done the renaming as well as all the other changes >> you've requested except for moving the helper files into a >> subdirectory. I've pushed them to a new >> concurrent-sync-sessions-for-review branch[1]. >> >> As mentioned above renaming has increased the changed line count. I've >> got a branch with all the changes minus the renaming if you'd rather >> have that. > > Please push it, I'll have a look. > Done. It's named concurrent-sync-sessions-for-review-before-rename[1]. Cheers, chris [1] https://meego.gitorious.org/meego-middleware/syncevolution/commits/concurrent-sync-sessions-for-review-before-rename _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
