(Removing Chris from CC). 2012/4/12 Patrick Ohly <[email protected]>: > On Thu, 2012-03-29 at 14:30 +0200, Patrick Ohly wrote: >> But before you rathole there, better focus on writing the tests against >> current master. That code should work and can serve as reference for the >> expected behavior (with sanity checks, of course - there might be bugs >> also in the old implementation). > > Please base your work on the current "for-master/cmdline-output" branch. > This includes the stdout/stderr change that I mentioned in my email > yesterday and also cleans up the output so that it is the same, with or > without syncevo-dbus-server. I'm currently running one final sanity > check on the automated test server and then will merge that branch into > master. > > Output checking is hard. Some parts of the output are variable, but > skipping over those parts entirely would miss cases where undesirable > output is included in them. > > For example, the current TestCmdline would not catch the extra "[ERROR] > command line execution failure" added by the execution inside the > syncevo-dbus-server when the operation failed. > > Probably a stricter regex would do the job: "output must start with > exactly this [ERROR], followed by this [INFO] line and then more [INFO] > lines of this format". > > In the meantime I'll merge these changes into the ccs-pohly branch.
Some of the tests are implemented in following branch: https://meego.gitorious.org/~krnowak/meego-middleware/krnowaks-syncevolution/commits/cmdline-tests-for-master-cmdline-output Commits are not so informative - will do it later. For now testTemplate is failing - I do not know whether this should be fixed in Cmdline or rather the test should be adapted to current behaviour. This place is marked as TODO. > > -- > Best Regards, Patrick Ohly > > The content of this message is my personal opinion only and although > I am an employee of Intel, the statements I make here in no way > represent Intel's position on the issue, nor am I authorized to speak > on behalf of Intel on this matter. > > _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
