On Fr, 2012-04-13 at 15:11 +0200, Krzesimir Nowak wrote: > 2012/4/13 Patrick Ohly <[email protected]>: > > On Do, 2012-04-12 at 15:59 +0200, Krzesimir Nowak wrote: > >> > In the meantime I'll merge these changes into the ccs-pohly branch. > > > > Branch updated and rebased, see ccs-pohly-cmdline. > > > >> Some of the tests are implemented in following branch: > >> https://meego.gitorious.org/~krnowak/meego-middleware/krnowaks-syncevolution/commits/cmdline-tests-for-master-cmdline-output > >> > >> Commits are not so informative - will do it later. > > > > And they are also incomplete, aren't they? stdout and stderr from > > running the command line tool are captured, but they are not checked > > anywhere. Nor is the return code checked. > > Forgot about the return code. stdout and stderr are captured in other > tests (like testPrintConfig - not yet pushed to my branch).
My point is that they should *always* be tested, even if it just to ensure that they are empty. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
