On 14/03/2012 15:40, Emmanuel Lécharny wrote:
Hi,
I see that this commit contains a *lot* of changes like :
@@ -146,26 +146,21 @@ public class Configuration extends BaseP
// Workflow definition stuff
final WorkflowDefinitionTO workflowDef =
wfRestClient.getDefinition();
- WebMarkupContainer workflowDefContainer =
- new WebMarkupContainer("workflowDefContainer");
+ WebMarkupContainer workflowDefContainer = new
WebMarkupContainer("workflowDefContainer");
which is a clear indication that some of you aren't using the same
indentation policy.
Hi Emmanuel,
this is happening because we used to have 80 columns constraint for code
lines but we moved to 120 columns contextually with Apache Syncope set up.
Now, as soon as I open a file formatted with former constraint, I just
ask my IDE to reformat and that's the result.
This makes the one reviewing your changes spending a hell of time
decyphering what is a real change from what is just formating.
I would suggest you define a formatter for your IDEs, which is common
to all of you. And use it. Plus apply the formatter to all the
existing files.
Just saying that because such formatting is noise...
I understand: I will try to keep separated formatting commits from
functional commits - as it should be.
Regards.
--
Francesco Chicchiriccò
Apache Cocoon PMC and Apache Syncope PPMC Member
http://people.apache.org/~ilgrosso/
