On 14/03/2012 17:05, Emmanuel Lécharny wrote:
Le 3/14/12 4:17 PM, Francesco Chicchiriccò a écrit :
Il 14/03/2012 16:04, Emmanuel Lécharny ha scritto:
I understand. Format *all* the files in one shot, then commit. That
would be way better than spreading such modifications in many commits.
It *would* be way better, but I'd prefer to check this instead of
relying upon IDE features only.
Why ? Are you using different IDE ? That's just fine, but that should
not impact the formatting.
In any case, formatting the *changed* code (and only the changed code)
is fine, but formatting the *unchanged* code is evil.
If your IDE is not smart enough not to format the entire file, then
change your IDE :)
There is nothing worst community wise than a bunch of such formatting
: it forbids the analysis of the commit, and makes the commit mails
useless.
I am not sure that non-functional, properly described commits would be
the worst things a community can get, but we have an old saying in my
town (it's a small country town, for your reference) that can be roughly
translated as "Bind the donkey where its master says" :-)
Hence, I will pause any other development activity, reformat all the
code, possibly relying upon some smart maven plugin which I trust more
than any IDE, and commit.
If you have to switch to 120 cars per line, do it in one shot.
I will.
Regards.
--
Francesco Chicchiriccò
Apache Cocoon PMC and Apache Syncope PPMC Member
http://people.apache.org/~ilgrosso/
