[
https://issues.apache.org/jira/browse/SYNCOPE-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473949#comment-13473949
]
Jan Bernhardt commented on SYNCOPE-219:
---------------------------------------
I created a Wiki-Page containing a sample workflow description and image, to
show how updating of suspended users could be enabled:
https://cwiki.apache.org/confluence/display/SYNCOPE/Updating+suspended+users
I replaced 'enabled' check in enableGW with 'syncopeUser.getSuspended()'. From
my point of view this 'enabled' attribute is redundant and should be removed. I
reviewed syncope core source code and as far as I can see, this attribute will
always be (and stay) null, except if a new user is created by synchronization
with an external system. But even in this case, I would rather call
'setSuspended(..)', instead of using this 'enabled' attribute. If you agree
with me, I could provide a patch fixing this behavior.
> Changing attributes of inactive users
> -------------------------------------
>
> Key: SYNCOPE-219
> URL: https://issues.apache.org/jira/browse/SYNCOPE-219
> Project: Syncope
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Priority: Minor
> Attachments: syncopeWorkflow.xml, Workflow-new.png
>
>
> I attached a visual representation of a modified workflow allows changing of
> attributes of suspended users (relied to [1]). I also attached a modified
> BPMN workflow for this purpose.
> After applying this workflow to my syncope instance I’ve got the effect, that
> users will be set active after any user updates. The attention was to be able
> of changing inactive (suspended) user attributes while these users remain
> inactive. I believe that the root cause for this behavior is that an
> attribute “enabled” is checked (Line 80) which is not set at this point. Why
> is this attribute (enabled) used instead of ${syncopeUser. getSuspended()} ?
> If the second case would be true, this should solve the current issue and
> then there would be no need for the AutoActivate serviceTask…
> In my opinion it should be possible to change attributes of suspended users
> by default. So my proposal would be to deliver my modified version with the
> standard installation of syncope.
> I also changed the naming in the workflow whenever possible without effecting
> the implementation to distinct between user workflows and other (e.g. roles,
> see SYNCOPE-173). My suggestion would be to move (refactor) all user workflow
> serviceTasks from “org.apache.syncope.core.workflow.activiti” to
> “org.apache.syncope.core.workflow.activiti.user”. By doing so it will be
> easier for SYNCOPE-173 to add role serviceTasks.
> [1]
> http://syncope-user.1051894.n5.nabble.com/Issue-with-importing-suspended-user-td5706694.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
