On 2025-07-26 at 15:53:59 UTC-0400 (Sat, 26 Jul 2025 12:53:59 -0700 (PDT)) John Hardin <sysadmins@spamassassin.apache.org> is rumored to have said:
> Folks: > > I'm trying to review some SpamAssassin commits via ViewVC and it's not > working reliably. The diffs are not being produced for commits, but they are > for individual files.. > > If you go to a specific file, you can see the current file data. > > If you click on the revision in the header, and then click "text changed" you > get a diff of that file: > > https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?pathrev=1927474&r1=1927474&r2=1927473#content Confirmed. > If you go to the log for the file and click "Diff to previous" on a revision > you get a page with the template text but the diff is missing: > > https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?r1=1927473&r2=1927474&diff_format=h That URL does show pathology, but I cannot reproduce it nor can I reach it by the path described. If I go to the log for 20_misc_testing.cf, navigating from the r1927474 "text changed" URL above, I am at this URL: https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?pathrev=1927474&view=log The "Diff to previous" link under r1927474 links to: https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1926024&r2=1927474&pathrev=1927474 I can find no way to get to any URL that adds a query string to a directory (i.e. jhardin/? above) and I don't know what ViewVC *should* do with such an URL. > > Attempting to generate a patch from a commit on the page with no diff content > throws a python exception. > > Potentially related: this reference in the HTML returns a 404: > https://svn.apache.org/vc-static/scripts.js That URL does return a 404 for me. If I insert /viewvc/ where I would expect it in a ViewVC URL, I get a slightly different 404 (mediated by ViewVC) The bad URL is referenced in every page load I try in ViewVC, even the ones that show a proper diff. The console shows the reference to it as a Content Security Policy, along with multiple CSS references. As far as I can tell, it has no ill effects. > Is this broken for others as well? I can't get to a visibly broken page. -- Bill Cole
