On Sat, 26 Jul 2025, Bill Cole wrote:
On 2025-07-26 at 15:53:59 UTC-0400 (Sat, 26 Jul 2025 12:53:59 -0700 (PDT))
John Hardin <sysadmins@spamassassin.apache.org>
is rumored to have said:
Folks:
I'm trying to review some SpamAssassin commits via ViewVC and it's not working
reliably. The diffs are not being produced for commits, but they are for
individual files..
If you go to a specific file, you can see the current file data.
If you click on the revision in the header, and then click "text changed" you
get a diff of that file:
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?pathrev=1927474&r1=1927474&r2=1927473#content
Confirmed.
If you go to the log for the file and click "Diff to previous" on a revision
you get a page with the template text but the diff is missing:
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?r1=1927473&r2=1927474&diff_format=h
That URL does show pathology, but I cannot reproduce it nor can I reach it by the path
described. If I go to the log for 20_misc_testing.cf, navigating from the r1927474
"text changed" URL above, I am at this URL:
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?pathrev=1927474&view=log
The "Diff to previous" link under r1927474 links to:
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1926024&r2=1927474&pathrev=1927474
I can find no way to get to any URL that adds a query string to a directory
(i.e. jhardin/? above) and I don't know what ViewVC *should* do with such an
URL.
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf
-> topmost "Diff To Previous" link there is
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1927474&r2=1927486
-> "colored" link next to that is
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/20_misc_testing.cf?r1=1927474&r2=1927486&diff_format=h
That all works.
A directory page
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/
-> jhardin directory "Last change" link is
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?view=log
-> topmost "Diff to Previous" link there is
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?r1=1927474&r2=1927486
No diff content or modified files list
-> Changing diff type to "colored diff" gives
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?r1=1927474&r2=1927486&diff_format=h
No diff content or modified files list
-> "Generate Patch" link is
https://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/jhardin/?r1=1927474&r2=1927486&view=patch
Returns Python error traceback (empty)
I was mistaken about the log for a specific file in my narrative, it's the
log for a *directory*. Apologies for that.
Potentially related: this reference in the HTML returns a 404:
https://svn.apache.org/vc-static/scripts.js
That URL does return a 404 for me. If I insert /viewvc/ where I would expect it
in a ViewVC URL, I get a slightly different 404 (mediated by ViewVC)
The bad URL is referenced in every page load I try in ViewVC, even the ones
that show a proper diff. The console shows the reference to it as a Content
Security Policy, along with multiple CSS references. As far as I can tell, it
has no ill effects.
I suspect the path I gave is valid because this is also in the page
source:
<a href="/vc-static/help_rootview.html">ViewVC Help</a>
...which leads to:
https://svn.apache.org/vc-static/help_rootview.html
...without /viewvc/
Is this broken for others as well?
I can't get to a visibly broken page.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhar...@impsec.org pgpk -a jhar...@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
A government is a lot like a gun: It's always loaded,
and it's stupid and dangerous to point it at anything
you don't intend to hurt. -- GOF at TSM
-----------------------------------------------------------------------
8 days until the 290th anniversary of John Peter Zenger's acquittal
